search

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
152 stars 43 forks source link

Deprecation of feature writer modes? #611

Open madig opened 2 years ago

madig commented 2 years ago

I just (re)learned that the recommended method to use feature writers is to leave their defaults (i.e. don't use a custom com.github.googlei18n.ufo2ft.featureWriters) and use Glyphs.app-style # Automatic Code comments inside manually written feature blocks to add custom additions before or after the autogenerated ones (or replace the block with the autogenerated ones).

Should writer modes then be completely deprecated and log a warning? Ditto for feature blocks without the comments being ignored?

madig commented 2 years ago

The fontmake documentation contains some notes about this: https://github.com/googlefonts/fontmake/blob/main/USAGE.md#feature-writing.

I suppose it should be updated to reflect the recommendation with clearer wording? Also not entirely happy that the documentaiton for this and the actual functionality are in different packages... This should at least be made clearer in ufo2ft's docstrings (see e.g. BaseFeatureWriter).