googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
151 stars 43 forks source link

outlineTTFCompiler: set overlap bits for ttGlyph #615

Closed m4rc1e closed 1 year ago

m4rc1e commented 2 years ago

I have a few PRs I'm working on which should enable users to manually set which glyphs should have overlap bits enabled. I also plan to automatically calculate these bits of the user hasn't specified any glyphs.

Depends on https://github.com/fonttools/ufoLib2/pull/217, https://github.com/robotools/defcon/pull/404 and a fontTools pen pr I'm working on. The auto stuff is a touch harder so I may need to revise this PR at some point.

jenskutilek commented 2 years ago

The overlap bits are supported by #577 along with all the rest of public.truetype. I think energy is better spent by someone reviewing that PR ;) Maybe you would like to have a go at it?

jenskutilek commented 2 years ago

Now that PR moved to #653. It will still include a solution for this issue.

anthrotype commented 1 year ago

@jenskutilek IIUC, in https://github.com/googlefonts/ufo2ft/pull/654, we only added support for setting OVERLAP_COMPOUND flag for glyf components, but not also the OVERLAP_SIMPLE flag for simple contour glyphs, am I right? So we still need to support passing along the info stored in UFO's public.truetype.overlap lib key to the TTGlyphPointPen.glyph() method or set the flag in ufo2ft after the fonttools pen has returned the TTGlyph to us.