googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
151 stars 43 forks source link

[DottedCircleFilter] Don't add a new OPENTYPE_CATEGORIES lib #624

Closed simoncozens closed 2 years ago

simoncozens commented 2 years ago

If the dotted circle filter doesn't find a GDEF statement while trying to make the dotted circle glyph into a base glyph, it adds the glyph to the OPENTYPE_CATEGORIES part of the font's lib instead. If there isn't a OPENTYPE_CATEGORIES lib, it makes one. This is a mistake, because the dotted circle glyph becomes the only thing in OPENTYPE_CATEGORIES, and everything else not in the dictionary is assumed to be base; this is not what you want.