Closed simoncozens closed 1 year ago
A second side note is that this happens even in glyphs which are set to non-exporting, which shouldn't happen anyway.
Are we sure a WARNING is better than a (probably better phrased) error in this case? A missing component is probably bad and should be caught at build time. Warnings can be ignored.
this happens even in glyphs which are set to non-exporting, which shouldn't happen anyway.
this should be investigated further, because I think preprocessor already takes care of excluding the non-exported glyphs from the glyph set that is passed to the filters, so FlattenComponentsFilter should not even see those..
Nope, I'm wrong - I was changing the exported glyphs of a Glyphs file but compiling the intermediate UFO. The glyphset issue is fine, so I'm happy to make this a hard error.
If I use fontmake on a Glyphs file which contains components with missing base glyphs, I get errors like this:
(Side note: there are many cases where fontmake eats the original exception like this, and produces weird and inscrutable errors. We should hunt down all of them.)
With this PR, the font compiles with warnings: