search

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
152 stars 43 forks source link

Make it possible to have custom name for anchors in cursFeatureWriter. #672

Open typoman opened 2 years ago

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

khaledhosny commented 2 years ago

FWIW, Glyphs app supports multiple exit/entry pairs (e.g. exit_1/entry_1 etc.) and we want to eventually support this, so it should be kept in mind when designing API now so we do}t have to do breaking changes later or awkward workarounds.

anthrotype commented 2 years ago

multiple exit/entry pairs (e.g. exit_1/entry_1 etc.)

how do these works?

khaledhosny commented 2 years ago

multiple exit/entry pairs (e.g. exit_1/entry_1 etc.)

how do these works?

I don’t know yet (that is the eventually bit). It is on my radar, but I don’t currently have a font that need this (I had one, but I painstakingly forced it to use a single exit/entry pair when I ported it from FontForge to Glyphs, before Glyphs app had this).