Automatically decompose when 2x2 transforms differ

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).

MIT License

152 stars 43 forks source link

Automatically decompose when 2x2 transforms differ #698

Closed simoncozens closed 1 year ago

simoncozens commented 1 year ago

This fixes #507 (again).

Decompose glyphs if they have non-matching transforms
Compare the relevant part of the transformation only
Add a test

anthrotype commented 1 year ago

can you also check if https://github.com/googlefonts/ufo2ft/issues/695 gets fixed by this too?

simoncozens commented 1 year ago

I'm not sure. It looks OK to me, but it also looks OK with the main branch as well. However, it was previously giving

WARNING:fontTools.varLib:glyph Ohorntilde has incompatible masters; skipping

and now it doesn't, so maybe?

anthrotype commented 1 year ago

yeah, that's it! varLib is dropping the variations for that composite glyph because the master components' transforms do not match (I think as result of this recent change in fonttools => https://github.com/fonttools/fonttools/pull/2857)

anthrotype commented 1 year ago

if you drop the font built with this branch in fontgoggles and type "ỡỠ" do both vary as you move along the wght axis? /cc @yanone

in that case, I would mark #695 as fixed by this as well

simoncozens commented 1 year ago

Yes, they do. But as I said, they seemed to do that for me before. I think it might involve different versions of fonttools too.