search

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
152 stars 43 forks source link

Register lookups for all defined languages #711

Closed madig closed 1 year ago

madig commented 1 year ago

Closes https://github.com/googlefonts/ufo2ft/issues/699.

I'm not sure about:

  1. Should we also consider languages defined for DFLT? The spec technically allows this but I don't know if it's a valid use case?
  2. If the designer defined a language for e.g. the OT tag tml2, should it also be inserted for taml?
anthrotype commented 1 year ago

Should we also consider languages defined for DFLT?

yes, I think so, if they are expliclity defined, I don't see why we should exclude those

If the designer defined a language for e.g. the OT tag tml2, should it also be inserted for taml?

no, we should only do what being told

madig commented 1 year ago

Validated these changes with https://github.com/daltonmaag/kerning-validator/commit/16927fc10b1f4d83d0f2b029b4c1b16a8d5c7efe.