search

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
151 stars 43 forks source link

Revert "Don't skip over spacing marks when kerning (#720)" #722

Closed anthrotype closed 1 year ago

anthrotype commented 1 year ago

This reverts PR #720 while we find a fix for https://github.com/googlefonts/ufo2ft/issues/721

simoncozens commented 1 year ago

I don't agree with reverting this. #720 is helpful in the small (but real) corner case of kerning between spacing combining marks. I don't think we should revert that benefit just because it crashes in the vanishingly tiny case of spacing marks with zero width in some masters.

anthrotype commented 1 year ago

ok.. but what would you do (or recommend users to do) as a workaround in that specific case?

simoncozens commented 1 year ago

If they want all masters to be treated as non-spacing, set the zero-width master to have width==1 unit.

anthrotype commented 1 year ago

let's hope this doesn't bite us later on

madig commented 1 year ago

Is this documented or warned about anywhere?

anthrotype commented 1 year ago

let's hope this doesn't bite us later on

could https://github.com/googlefonts/fontmake/issues/894#issuecomment-1699524088 be it biting us?