search

googlefonts / ufo2ft

A bridge from UFOs to FontTools objects (and therefore, OTFs and TTFs).
MIT License
151 stars 43 forks source link

Respect overrides due to openTypeNameRecords for the predefined name IDs #727

Closed IvanUkhov closed 1 year ago

IvanUkhov commented 1 year ago

Closes #726.

IvanUkhov commented 1 year ago

@anthrotype, added a test. Please take a look.

anthrotype commented 1 year ago

the "tests/data/TestFont.ufo" file might be used in other tests, maybe it's preferable to not change that one, but perhaps you load it as is, add the custom openTypeNameRecords to the lib and the pass it on to the OutlineCompiler for testing?

IvanUkhov commented 1 year ago

Yes, you are right. Created a separate file.

IvanUkhov commented 1 year ago

Sorry. Did not notice yesterday that the linter was complaining. Should be good now.