Closed zmerlynn closed 1 year ago
One question on
On game server pods, Agones defaults to cluster-autoscaler.kubernetes.io/safe-to-evict=false annotation - this can be mitigated with https://github.com/googleforgames/agones/issues/2747
The current mitigation will require that any fleet spec being moved from non-autopilot to autopilot will need to be updated to add extra metadata. It would be nice in the longer term if we could better support upgrades (across all platforms) and switch the default behavior to allow a safe eviction but give folks the chance to prevent it if that doesn't work for their game server.
One question on
On game server pods, Agones defaults to cluster-autoscaler.kubernetes.io/safe-to-evict=false annotation - this can be mitigated with #2747
The current mitigation will require that any fleet spec being moved from non-autopilot to autopilot will need to be updated to add extra metadata. It would be nice in the longer term if we could better support upgrades (across all platforms) and switch the default behavior to allow a safe eviction but give folks the chance to prevent it if that doesn't work for their game server.
I debated this, and it again comes to explicit intent vs transparently working: One possible option is that we just set this annotation to be true on Autopilot, but that doesn't seem necessarily correct either.
@zmerlynn I think this can be closed now, yeah?
Is your feature request related to a problem? Please describe.
Agones has a number of friction points on GKE Autopilot:
denied by autogke-no-host-port
)cluster-autoscaler.kubernetes.io/safe-to-evict=false
to minimize disruption (denied by autogke-node-affinity-selector-limitation
):cluster-autoscaler.kubernetes.io/safe-to-evict=false
annotation - this can be mitigated with #2747Note that Autopilot issues were previously brought up in #2249 - the state of the world has changed considerably since then (mutating webhooks are now allowed), but there are still friction points.
Describe the solution you'd like
I propose the following:
portPolicy
isDynamic
(we may be able to supportPassthrough
later, but let's start here)safe-to-evict=false
(#2797).