agones-ping merge to use a single port

[aimuz]

I have noticed so far that agones-ping service provides two services to the public, but observed that they are both provided by one port.

Based on this can we combine agones-ping-http-service and agones-ping-udp-service into one service

.e.g.

apiVersion: v1
kind: Service
metadata:
  annotations:
    meta.helm.sh/release-name: agones
    meta.helm.sh/release-namespace: agones-system
  labels:
    app: agones
    app.kubernetes.io/managed-by: Helm
    chart: agones-1.32.0
    component: ping
    heritage: Helm
    release: agones
  name: agones-ping
  namespace: agones-system
spec:
  ports:
  - name: http
    port: 80
    protocol: TCP
    targetPort: 8080
  - name: udp
    port: 80
    protocol: UDP
    targetPort: 8080
  selector:
    agones.dev/role: ping
  sessionAffinity: None
  type: LoadBalancer

[markmandel]

We should double check, but I think at the time of writing UDP/TCP through a single LB wasn't supported on all clouds, so we split them. We should go back and look to see if that's still the case - but also - backward compatibility, so we could have this as an option, but maintain the default.

[aimuz]

Does this problem still exist for different ports?

[markmandel]

Honestly, I can't actually remember. Would need to go check.

[github-actions[bot]]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[github-actions[bot]]

This issue is marked as obsolete due to inactivity for last 60 days. To avoid issue getting closed in next 30 days, please add a comment or add 'awaiting-maintainer' label. Thank you for your contributions