search

googleforgames / agones

Dedicated Game Server Hosting and Scaling for Multiplayer Games on Kubernetes
https://agones.dev
Apache License 2.0
6k stars 791 forks source link

Duplicate name collision for Agones events delegates in Unreal engine plugin #3347

Closed fraglab-admin closed 6 days ago

fraglab-admin commented 1 year ago

AgonesComponent.h in Unreal plugin exposes list of delegates with generic names. These names are potentially can be collided with other similar plugins. For example our project uses Agones and Unity Mulitplay plugin which has the same naming for similar events. Particularly the problem is in FAllocateDelegate which is the same Unity Multiplay plugin delegate.

It would be nice to add some kind of code separation to isolate events, for example namespace Agones or Agones prefix.

As temporary solution we have changed FAllocateDelegate to FAgonesAllocateDelegate

It is reproducible in 1.32 version. File AgonesComponent.h. Delegate FAllocateDelegate.

markmandel commented 1 year ago

Asking this question as someone who has no idea about Unreal engine 😄 Is there a way we can do this while also being backward compatible? Or would we need to break an API surface?

github-actions[bot] commented 1 month ago

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

github-actions[bot] commented 3 weeks ago

This issue is marked as obsolete due to inactivity for last 60 days. To avoid issue getting closed in next 30 days, please add a comment or add 'awaiting-maintainer' label. Thank you for your contributions