googleforgames / agones

Dedicated Game Server Hosting and Scaling for Multiplayer Games on Kubernetes
https://agones.dev
Apache License 2.0
6.09k stars 810 forks source link

Switch to buf.build #3367

Closed aimuz closed 1 month ago

aimuz commented 1 year ago

Is your feature request related to a problem? Please describe.

I should simplify the development process and ensure that the results of script execution are idempotent

When I run make gen-all-sdk-grpc locally I get something different from ci

diff --git a/pkg/sdk/alpha/alpha.pb.go b/pkg/sdk/alpha/alpha.pb.go
index 9077961e4..7a8124af8 100644
--- a/pkg/sdk/alpha/alpha.pb.go
+++ b/pkg/sdk/alpha/alpha.pb.go
@@ -30,7 +30,7 @@
 // Code generated by protoc-gen-go. DO NOT EDIT.
 // versions:
 //     protoc-gen-go v1.28.1
-//     protoc        v3.21.6
+//     protoc        v3.21.12
 // source: alpha.proto

 package alpha
diff --git a/pkg/sdk/alpha/alpha_grpc.pb.go b/pkg/sdk/alpha/alpha_grpc.pb.go
index 5aab5b156..dda8e6178 100644
--- a/pkg/sdk/alpha/alpha_grpc.pb.go
+++ b/pkg/sdk/alpha/alpha_grpc.pb.go

This PR presence is relevant https://github.com/googleforgames/agones/pull/3366

And when I run it for the first time, it's very slow and spends most of its time executing this command

RUN git clone --recurse-submodules -b $GRPC_RELEASE_TAG --depth 1 --shallow-submodules https://github.com/grpc/grpc /var/local/git/grpc && \
    cd /var/local/git/grpc && \
    mkdir -p cmake/build && \
    cd cmake/build && \
    cmake -DCMAKE_BUILD_TYPE=Release -DgRPC_INSTALL=ON -DgRPC_BUILD_TESTS=OFF ../.. && \
    make -j$(nproc) && make install

If we can improve it, this will be great.

I proposed an option to switch to https://buf.build/docs/generate/overview , a tool that I think greatly simplifies the development process!

Describe the solution you'd like

Describe alternatives you've considered

Additional context

github-actions[bot] commented 3 months ago

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

github-actions[bot] commented 2 months ago

This issue is marked as obsolete due to inactivity for last 60 days. To avoid issue getting closed in next 30 days, please add a comment or add 'awaiting-maintainer' label. Thank you for your contributions