googleforgames / agones

Dedicated Game Server Hosting and Scaling for Multiplayer Games on Kubernetes
https://agones.dev
Apache License 2.0
6k stars 791 forks source link

Missing agones_k8s_client_cache_* metrics #3540

Open Kalaiselvi84 opened 8 months ago

Kalaiselvi84 commented 8 months ago

What happened:

Setup of a GKE Autopilot cluster with Agones was completed, and Prometheus was configured for collecting metrics. During the setup of Grafana dashboards, it was observed that the agones_k8s_client_cache_* metrics are missing. These metrics are not present in the Prometheus exports from the /metrics endpoints of any services.

What you expected to happen:

Expected the agones_k8s_clientcache* metrics in Grafana dashboards

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

It's possible that the metrics exported from client-go have changed. Relevant code is here, in case you want to take a look: https://github.com/googleforgames/agones/blob/e5d89bc2f47c6a34662c6afa6f1a057e250f81a8/pkg/metrics/kubernetes_client.go#L199C8-L199C35

Environment:

markmandel commented 8 months ago

Just noting that I'm seeing this in GKE standard, as well - I don't think it's an autopilot issue - I think something changed in client-go somewhere.

github-actions[bot] commented 3 weeks ago

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

markmandel commented 3 weeks ago

One day I'd like to work out what went wrong here.