Support GameServer.Spec.SdkServer.LogLevel "Trace" - Githubissues

googleforgames / agones

Dedicated Game Server Hosting and Scaling for Multiplayer Games on Kubernetes

https://agones.dev

Apache License 2.0

6.03k stars 799 forks source link

Support GameServer.Spec.SdkServer.LogLevel "Trace" #3969

Open markmandel opened 3 weeks ago

markmandel commented 3 weeks ago

What happened:

I wanted to see some trace level debugging in the sidecar -- and I couldn't 😭

What you expected to happen:

Be able to use trace in the GameServer.Spec.SdkServer.LogLevel field.

How to reproduce it (as minimally and precisely as possible):

Try it! It won't validate!

Anything else we need to know?:

Environment:

Agones version: dev
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Install method (yaml/helm):
Troubleshooting guide log(s):
Others:

markmandel commented 2 weeks ago

Will need to:

Edit the CRD specification here to add "Trace":

https://github.com/googleforgames/agones/blob/d749f6393996b8a2695fb146a1e1c4dc37a91a76/install/helm/agones/templates/crds/_gameserverspecschema.yaml#L99-L110

Code that sets the log level is here: https://github.com/googleforgames/agones/blob/d749f6393996b8a2695fb146a1e1c4dc37a91a76/cmd/sdk-server/main.go#L76

I don't think the code needs changing, but if you could do a manual test (create a GameServer with Trace debugging), that would be ideal.