Closed deflaux closed 8 years ago
LGTM
Nicole, looks great, and might also want to bump com.google.protobuf
to version 3.0.0-beta-2
at the following line:
https://github.com/deflaux/dataflow-java/blob/45875de998bde6433e82bf70817d4560483f670e/pom.xml#L210
~p
Will fix that. Thanks @pgrosu !
Thanks Nicole :smile:
Fixes https://github.com/googlegenomics/dataflow-java/issues/163
Manually testing via
mvn verify
right now. Travis CI will turn green when utils-java makes it onto maven central.Will wait to merge till both those are complete.