googlegenomics / pipelines-api-examples

Examples for the Google Genomics Pipelines API.
BSD 3-Clause "New" or "Revised" License
50 stars 31 forks source link

Cromwell 0.24 #48

Closed CarlosBorroto closed 7 years ago

CarlosBorroto commented 7 years ago

Updating Cromwell launcher container image to support latest 0.24 upstream release.

Also added accepting Submitted in addition to Running as a temporary status response from Cromwell. I had a couple of failed executions with this Cromwell response status and the driver assumed a failure.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


CarlosBorroto commented 7 years ago

I signed the CLA. Both for my individual contributions and for my company.

googlebot commented 7 years ago

CLAs look good, thanks!

mbookman commented 7 years ago

Hi Carlos. Thank-you for the submission. I have an almost identical change ready in my fork:

https://github.com/googlegenomics/pipelines-api-examples/compare/master...mbookman:master

I am currently coordinating with @vdauwera to publish the wdl_runner docker image to gcr.io/broad-dsde-outreach/wdl_runner.

CarlosBorroto commented 7 years ago

@mbookman great to hear. Closing this then.