search

googlegenomics / utils-java

Common Java files for Google Genomics integrations.
Apache License 2.0
5 stars 11 forks source link

Don't set the RG tag using read.getReadGroupId() #115

Closed calbach closed 7 years ago

calbach commented 7 years ago

In practice these values have different semantics. In the Readstore API, the readGroupId is a server-generated ID which corresponds to a read group that the user imported. Every Read in the Readstore belongs to a read group, meaning that even if the original caller imported reads without a read group, we would allocate a new one for them.

This "RG" tag will already be set everywhere we would want to consume it downstream.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 62.402% when pulling c291da93ed7eb3144841505ac6ec83af04ec98ae on calbach-patch-1 into 2429242cf4caa0edd8c63d561aeb9591f20b0c17 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 62.402% when pulling c291da93ed7eb3144841505ac6ec83af04ec98ae on calbach-patch-1 into 2429242cf4caa0edd8c63d561aeb9591f20b0c17 on master.