search

googleinterns / Pictophone

Visual telephone web game, by STEP 2020 Pod 119.
http://phoebeliang-step.appspot.com/
Apache License 2.0
3 stars 2 forks source link

Game link redirection for signed-out user #37

Open tomatocat opened 4 years ago

tomatocat commented 4 years ago

Describe the bug When a user is signed out and they try to directly access a game link, they are redirected to the home page with no warning.

Expected behavior Somewhere in the redirection process, the user should be able to see a message telling them that they are being redirected because they must sign in to view game pages.

pl98 commented 4 years ago

This may need further discussion. This behavior currently exists because we want the user to be smoothly redirected after clicking the sign out button. Is showing a warning every time a user signs out going to be problematic in terms of user experience?

tomatocat commented 4 years ago

Yes, there should somehow be a difference between clicking the sign-out button vs. straight up trying to visit the game page while not logged in

pl98 commented 4 years ago

I have a feeling this might be a little difficult to implement based on how Firebase Auth works with the sign out process. This doesn't seem like a super high priority to me so I'll take a look at this some time next week.

tomatocat commented 4 years ago

yup, feel free to add priority tags to the issue. I didn't add the "final presentation" milestone because I think it's not 100% necessary.