googleinterns / amaranth

Apache License 2.0
2 stars 0 forks source link

Reformat project to fit the Python Package format #9

Closed tommylau-exe closed 4 years ago

tommylau-exe commented 4 years ago

Example guide can be found on Python's site here.

This change would put the code into modules, which it attempts to do already. This change would be beneficial because type checking tools and the Python runtime currently disagree on how to interpret the projects format. This makes is difficult to automate code checks, and potentially makes is more difficult for people to understand this project.

tommylau-exe commented 4 years ago

Not really sure if this is worth doing after all. Code is already fairly organized.

tommylau-exe commented 4 years ago

Another benefit would be sharing constants like the calorie thresholds. Reopening for this reason