search

googleinterns / blueprint-step-2020

Apache License 2.0
0 stars 2 forks source link

Add methods to Locations Utility for Go panel #147

Closed tttzach closed 4 years ago

tttzach commented 4 years ago

Add methods to Locations utility to generate all possible combinations of waypoints for the Go panel. The best of these combinations in terms of travel time is eventually chosen in the future. This PR only focuses on generating combinations.

gbuenoandrade commented 4 years ago

Refactor Locations utility for Go panel.

I think this PR seems to be adding a feature instead of refactoring code.

tttzach commented 4 years ago

@gbuenoandrade Yeah you're right, I might have twisted the definition of refactor on a lot of PRs. I'll change it!

tttzach commented 4 years ago

Can you make the PR description more specific? If I was looking at this PR in two weeks, I would have no idea what methods you are adding to Locations Utility and why.

Yeah absolutely, I'll go back and change all the PR titles and descriptions to be more descriptive. Thanks!