googleinterns / cloud-operations-api-mock

Apache License 2.0
5 stars 2 forks source link

Add additional validations for spans #28

Closed the-ericwang35 closed 4 years ago

the-ericwang35 commented 4 years ago

Adding in additional validations for tracing based on this doc. The additional checks are

Additional unit tests for these validations will be added in a separate PR since this one is already pretty large.

Since this involved creating a lot of new statuses, this PR also refactored them so that they're no longer exported, and the tests no longer do string comparison, as discussed in this issue. Lint issues for trace are also resolved in this PR.

the-ericwang35 commented 4 years ago

The lint errors are unrelated to this PR (we just added golint to the CI which is catching lint errors from before). See https://github.com/googleinterns/cloud-operations-api-mock/issues/30