googleinterns / cloud-operations-api-mock

Apache License 2.0
5 stars 2 forks source link

Remove custom RPCs and replace with getters #36

Closed the-ericwang35 closed 4 years ago

the-ericwang35 commented 4 years ago

Similarly, we don't need RPCs to allow exporter tests to get info about our server (retrieving number of spans, etc.). The only RPCs we need are for CreateSpan and BatchWriteSpans, since the exporter will call those via gRPC. This PR replaces the custom RPCs we created with getters, which makes them easier to use (we no longer have to have two clients) as well as makes them faster.