[Review - 2] Directory Manager - All APIs - Githubissues

googleinterns / filesystem-in-appsscript

Apache License 2.0

5 stars 1 forks source link

[Review - 2] Directory Manager - All APIs #32

Closed satviksr closed 4 years ago

satviksr commented 4 years ago

Implement

[X] FileDateTime
[X] FileLen
[X] ChDir
[X] ChDrive
[X] Dir
[X] Kill
[X] RmDir
[X] MkDir
[ ] name

Test

[X] FileDateTime
[X] FileLen
[X] ChDir
[ ] ChDrive // Tests can be written after FileMapper is complete
[X] Dir
[X] Kill
[X] RmDir
[X] MkDir
[ ] name

Update: Defer Name API Implementation, Issue has been raised #56

todo[bot] commented 4 years ago

Handle user locale

Currently using US/English locale

https://github.com/googleinterns/filesystem-in-appsscript/blob/d5883222368f2566d629ad3309d0be142baf9f9d/FileSystem/DirectoryManager.js#L118-L123

This comment was generated by todo based on a `todo` comment in d5883222368f2566d629ad3309d0be142baf9f9d in #32. cc @googleinterns.

todo[bot] commented 4 years ago

Handle user locale for datatime

Currently using US/English locale

https://github.com/googleinterns/filesystem-in-appsscript/blob/af362e401d3a9df876585f6ec0f3454543da24b1/FileSystem/DirectoryManager.js#L118-L123

This comment was generated by todo based on a `todo` comment in af362e401d3a9df876585f6ec0f3454543da24b1 in #32. cc @googleinterns.

todo[bot] commented 4 years ago

Write tests for ChDrive

ChDrive cannot be tested by the File Mapper Mocker as the mocker

https://github.com/googleinterns/filesystem-in-appsscript/blob/4864afa816c08ee31de2d7c531dfa5b7e163d808/FileSystem/DirectoryManager.js#L178-L183

This comment was generated by todo based on a `todo` comment in 4864afa816c08ee31de2d7c531dfa5b7e163d808 in #32. cc @googleinterns.

todo[bot] commented 4 years ago

Kill API: Throw error if file is open

https://github.com/googleinterns/filesystem-in-appsscript/blob/4864afa816c08ee31de2d7c531dfa5b7e163d808/FileSystem/DirectoryManager.js#L231-L236

This comment was generated by todo based on a `todo` comment in 4864afa816c08ee31de2d7c531dfa5b7e163d808 in #32. cc @googleinterns.