search

googleinterns / filesystem-in-appsscript

Apache License 2.0
5 stars 1 forks source link

Feature/api workbook open #4

Closed satviksr closed 4 years ago

satviksr commented 4 years ago

Setup the basic FileSystem files

  1. VBA File Mapper Mocker
  2. Workbook open API with tests
  3. Test Framework

The return value of Workbook.open returns Workbook. So I thought it is best to replicate that behavior as well. Should I remove it?

https://docs.microsoft.com/en-us/office/vba/api/excel.workbooks.open#return-value

Previous PR: #1

todo[bot] commented 4 years ago

Better Error Reporting

https://github.com/googleinterns/filesystem-in-appsscript/blob/f0b000e666f6ae3dfe1e8516e194070544ec4fa9/FileSystem/TestFramework.js#L6-L11

This comment was generated by todo based on a todo comment in f0b000e666f6ae3dfe1e8516e194070544ec4fa9 in #4. cc @googleinterns.
todo[bot] commented 4 years ago

separate out workbook APIs from FileSystem APIs

https://github.com/googleinterns/filesystem-in-appsscript/blob/f0b000e666f6ae3dfe1e8516e194070544ec4fa9/FileSystem/Workbook.js#L4-L9

This comment was generated by todo based on a todo comment in f0b000e666f6ae3dfe1e8516e194070544ec4fa9 in #4. cc @googleinterns.
todo[bot] commented 4 years ago

implement currentDirectory

https://github.com/googleinterns/filesystem-in-appsscript/blob/d716c1eb17fc99441dad2d79b7868b3ba64f2389/FileSystem/Workbook.js#L4-L9

This comment was generated by todo based on a todo comment in d716c1eb17fc99441dad2d79b7868b3ba64f2389 in #4. cc @googleinterns.