search

googleinterns / play-movies-2020-intern

Apache License 2.0
1 stars 1 forks source link

Combine Home/Liked/Disliked fragments into AssetListFragment #26

Closed jackstenglein closed 4 years ago

jackstenglein commented 4 years ago

Removes the separate HomeFragment, LikedFragment and DislikedFragment classes and has each screen instead use the AssetListFragment class. Also renames the usecase.component package to usecase.assetList, as it currently contains only items related to the AssetListFragment. Small changes are made to the HiltFragmentScenario class in order to support launching the AssetListFragment with arguments. Tests checking the behavior from the HomeFragmentTest and LikedFragmentTest classes are moved to the AssetListFragmentTest class and the previous test classes are removed.

jackstenglein commented 4 years ago

I've noticed that the tests are failing again, but this appears to be unrelated to the previous issue. Before, the tests were failing with incorrect values, and now the emulator is crashing. It seems to do this when it reaches the SigninActivityTest class, which is strange, as the SigninActivity has not been changed in a while. The SigninActivityTest class still works on my local machine, and in fact, I have not seen it fail locally yet. I'm not sure yet what the reasons could be for the failures in the continuous integration.

TianyiMu commented 4 years ago

Looks like a ci issue. Passed when I return.