search

googleinterns / smart-home-testing

Apache License 2.0
1 stars 2 forks source link

Validate function #23

Closed jolene-loz closed 4 years ago

jolene-loz commented 4 years ago

Validating a SYNC response

Fleker commented 4 years ago

If you can rebase this on the master branch your diff will be smaller.

Fleker commented 4 years ago

Overall LGTM with a few comments.

jolene-loz commented 4 years ago

LGTM so far. I presume the changes for trait validation and cleanup of response type are coming in a future PR?

Yes that's correct! Both of those are on two separate PRs right now.