Structure code - Githubissues

googleinterns / step228-2020

1 stars 0 forks source link

Closed Anya1234 closed 4 years ago

Anya1234 commented 4 years ago

Divided code of script.js into some files to have a less code in a one place

Anya1234 commented 4 years ago

union won't be unused after merging

ioanalazar42 commented 4 years ago

Things done in this previous commit:

copy the js code that styles YouTube and Twitter buttons from branch twitter-yt-buttons-style
- needs the CSS file in dev to work (styling will only work once this is merged)
fix window bug:
- data was refetched even when clicking on the same marker
- opening a different window without closing the previous one caused data to not be visible anymore
remove duplicate variable countriesWithSomeData and useless method call getSupportedCountries()

ioanalazar42 commented 4 years ago

Copied the css file from the last merged PR. Now can be tested properly