search

googleinterns / step229-2020

1 stars 1 forks source link

Check permissions returned. #19

Closed tblanshard closed 4 years ago

tblanshard commented 4 years ago

Check the permissions returned from the java servlet and display an appropriate message to the user.

Update test to match new return type.

@andreeanica16 @iht - thank you :)

tblanshard commented 4 years ago

I'm not entirely sure what the process is if changes are requested, but then another commit is made which would make those changes redundant as the lines mentioned have been changed/ the changes have already been implemented in the new merge?

iht commented 4 years ago

You need to submit new commits. If those commits are changing those lines, then the "changes requested" are canceled. No check is done if the changes requested actually are matching the changes done in the commits. As long as the commits change the same lines, they are considered as addressing the changes. The reviewer would have to make that check.