search

googleinterns / step28-2020

1 stars 1 forks source link

Common pagination #49

Closed tonioshikanlu closed 4 years ago

tonioshikanlu commented 4 years ago

Adds common card UI and pagination to every page

ryan-draper commented 4 years ago

Can we see screenshots of the personalization and trending pages?

tonioshikanlu commented 4 years ago
Screen Shot 2020-07-31 at 10 17 15 PM
tonioshikanlu commented 4 years ago
Screen Shot 2020-07-31 at 10 17 29 PM
tonioshikanlu commented 4 years ago
Screen Shot 2020-07-31 at 10 17 35 PM
ryan-draper commented 4 years ago

Can we remove the grey match/trending titles from the top of the cards? That's how it has been on the browse page which looks more clean imo.

tonioshikanlu commented 4 years ago

Are we going to display a portion of the description on the cards?

No I left the description only on the browse page. Should I include it on the trending and personalization pages?

charu0291 commented 4 years ago

Can we remove the grey match/trending titles from the top of the cards? That's how it has been on the browse page which looks more clean imo.

Making the cards same across site can be done in a separate PR. lets not block this PR..which takes care of pagination

tonioshikanlu commented 4 years ago

Please add the UI changes that we discussed in meeting. Let us know once done

Do you mind if I make those changes in a separate PR? Those things are a bit separate and I'd prefer to compartmentalize each part.

charu0291 commented 4 years ago

Please add the UI changes that we discussed in meeting. Let us know once done

Do you mind if I make those changes in a separate PR? Those things are a bit separate and I'd prefer to compartmentalize each part.

Yes, sg.