googleinterns / vba-migrator-addin

2 stars 0 forks source link

Code review-1 #3

Closed jyokush closed 4 years ago

jyokush commented 4 years ago

This code for add-in create the button in VBA Editor.

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

satviksr commented 4 years ago

@jyokush the CLA error is coming because Google wants all commits to have a google email id. I think you have configured on your local git correctly as some of the commits are having the green tick. In case you want to be sure just run - git config --global user.email "email@example.com"

But when you make a change directly on Github it isn't working because by default github hides your email address (privacy reasons). But you can change it of course, see the following link for the same - https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address. Ensure that you uncheck Keep my email address private

This will ensure that future commits will work fine. But to fix old commits, you may have to do this as described in this article - https://dev.to/chrisvasqm/how-to-change-the-author-of-all-your-commits-2j7a

Update: if the above method doesn't work try this -

git rebase --exec 'git commit --amend --no-edit --author "New Author Name <email@address.com>"' -i master
git push --force
googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.