search

googlemaps-samples / codelab-3d-maps-webgl-js

Apache License 2.0
27 stars 54 forks source link

Error showing code in the Documentation #6

Closed zeser78 closed 2 years ago

zeser78 commented 2 years ago

In this section https://developers.google.com/codelabs/maps-platform/webgl#3, it has a mistake showing the function initWebGLOverlayView(map) but it's WebglOverlayView() and inside this function webglOverlayView.onContextRestored = ({gl}) => {} and webglOverlayView.onDraw = ({gl, coordinateTransformer}) => {}, the parameters are without curly parentheses.

And here: https://developers.google.com/codelabs/maps-platform/webgl#5 , you use the parameter transformer, but in the rest of the documentation and sample code use coordinateTransformer.

zeser78 commented 2 years ago

Different name in Doc and Code in the initWebGLOverlayView() and initWebglOverlayView() function.

amuramoto commented 2 years ago

Fix incoming. Thanks!