googlemaps / android-maps-compose

Jetpack Compose composables for the Maps SDK for Android
https://developers.google.com/maps/documentation/android-sdk/maps-compose
Apache License 2.0
1.16k stars 143 forks source link

Wrong version in toml file: `"android-core"` #605

Closed yogurtearl closed 4 months ago

yogurtearl commented 4 months ago

Problem:

Bad metadata in the published pom file: https://repo1.maven.org/maven2/com/google/maps/android/maps-compose-utils/6.1.0/maps-compose-utils-6.1.0.pom

Actual

<dependency>
  <groupId>androidx.core</groupId>
  <artifactId>core-ktx</artifactId>
  <version>android-core</version>
  <scope>runtime</scope>
</dependency>

Expected

<dependency>
  <groupId>androidx.core</groupId>
  <artifactId>core-ktx</artifactId>
  <version>1.13.1</version>
  <scope>runtime</scope>
</dependency>

Cause:

This line is wrong:

https://github.com/googlemaps/android-maps-compose/blob/01ee126fb44031ae5f7691df2fc376fc1d28b36c/gradle/libs.versions.toml#L28

It should be version.ref not version

Something like

 androidx-core = { module = "androidx.core:core-ktx", version.ref = "androidx-core" } 

with this at the top of the file in the [versions] section.

androidx-core = "1.13.1"
kikoso commented 4 months ago

Thanks for reporting this @yogurtearl . This PR will fix the problem.

googlemaps-bot commented 4 months ago

:tada: This issue has been resolved in version 6.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: