googlemaps / google-maps-services-go

Go client library for Google Maps API Web Services
https://pkg.go.dev/googlemaps.github.io/maps
Apache License 2.0
737 stars 214 forks source link

feat: add ability to pass the experience id within the context #248

Closed fedor-shi closed 3 years ago

fedor-shi commented 3 years ago

In scenario when singleton SDK client used to make calls for different customers, setting the experienceId explicitly for every new call leads to the race conditions between the different requests.

I propose this PR to add ability passing the experienceId using context.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

jpoehnelt commented 3 years ago

LGTM, just need to sign CLA https://github.com/googlemaps/google-maps-services-go/pull/248#issuecomment-720489974

fedor-shi commented 3 years ago

@googlebot I signed it!

jpoehnelt commented 3 years ago

It's showing as not signed for the email associated with the commit and github account.

f**.s***@c****m.com

fedor-shi commented 3 years ago

It's showing as not signed for the email associated with the commit and github account.

f**.s***@c****m.com

hmm in the current agreement I put our team group e**-t**@c****m.com and my primary github account's email what you posted f****.s*****@c****m.com is the member of that group. Is there any hint what I can verify from my side, why is not visible on your side?

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jpoehnelt commented 3 years ago

I forced a rescan and it found it.

googlemaps-bot commented 3 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: