search

googlemaps / js-api-loader

Load the Google Maps JavaScript API script dynamically.
Apache License 2.0
351 stars 64 forks source link

deleteScript should be private #208

Open jpoehnelt opened 3 years ago

jpoehnelt commented 3 years ago

I am not aware of a valid use for deleteScript. It should be removed from the public class interface.

martijnmelchers commented 3 years ago

I disagree, we use it to unload the script on language change and load it back in with a new language.

chrisjshull commented 1 year ago

I disagree, we use it to unload the script on language change and load it back in with a new language.

FWIW, the API does not officially support doing that.

usefulthink commented 1 week ago

Once the maps API is starting to use WebComponents (currently in beta), it will no longer be possible to reload the Maps JavaScript API. See also my comment here: https://github.com/googlemaps/js-api-loader/issues/100#issuecomment-2407228459. Hence, there will no longer be support for this in the next major-release of the api-loader.