googlemaps / js-api-loader

Load the Google Maps JavaScript API script dynamically.
Apache License 2.0
347 stars 64 forks source link

Add conditional exports for Node ESM support #849

Closed thomaswelton closed 2 months ago

thomaswelton commented 4 months ago

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #821 🦕

Updated package.json to include conditional exports to support ESM imports in Node.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

usefulthink commented 2 months ago

this would be a breaking change, and we'll be adding this in the next major release, but we can't add this right now.