googlemaps / js-types

Automatically generated types for the Google Maps Platform JavaScript API
Apache License 2.0
8 stars 7 forks source link

Incorrect type in `google.maps.GeocoderRequest` #77

Open nbouvrette opened 1 year ago

nbouvrette commented 1 year ago

I'm not sure if this is the right place to fill this issue since I could not open issues on https://github.com/googlemaps/DefinitelyTyped

I've been writing wrappers on two common APIs, the autocomplete and the Geocoder.

I noticed the following type on autocomplete (google.maps.places.AutocompletionRequest) which looks like it maps to the API's request parameters.

I would presume that the Geocoder version (google.maps.GeocoderRequest) would have the same role but it contains a placeId which is not compatible with the place_id parameters from the Geocode API.

I might be misinterpreting the types and maybe they should not be used like this.

wangela commented 1 year ago

If you would like to upvote the priority of this issue, please comment below or react with :+1: so we can see what is popular when we triage.

@nbouvrette Thank you for opening this issue. 🙏 Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.