feat: add angular submodule

googlemaps / on-demand-rides-deliveries-samples

Apache License 2.0

15 stars 7 forks source link

feat: add angular submodule #4

Closed noelle-jung closed 2 years ago

noelle-jung commented 2 years ago

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes # 🦕

shawnlu-g commented 2 years ago

Hi @ShirwaM When the Angular submodule was added was the command git submodule add ... or something else?

noelle-jung commented 2 years ago

Hi @shawnlu-g

I added the Angular submodule with git submodule add https://github.com/googlemaps/angular-on-demand-rides-deliveries-samples.git

That modified .gitmodules to look like

[submodule "angular-on-demand-rides-deliveries-samples"]
    path = angular-on-demand-rides-deliveries-samples
    url = https://github.com/googlemaps/angular-on-demand-rides-deliveries-samples.git

which I changed manually to

[submodule "angular"]
    path = angular
    url = https://github.com/googlemaps/angular-on-demand-rides-deliveries-samples

(changed path and removed ".git" from the url) to follow the convention of the other submodules in .gitmodules.

shawnlu-g commented 2 years ago

Sorry Noelle, I think something didn't go well during the process, may need to redo. I believe the key is the 2nd argument of the git submodule add command

If you use

git submodule add https://github.com/googlemaps/angular-on-demand-rides-deliveries-samples.git angular-js

it may work well.

noelle-jung commented 2 years ago

Thanks @shawnlu-g , I opened a new PR https://github.com/googlemaps/on-demand-rides-deliveries-samples/pull/7