search

googlemaps / react-native-navigation-sdk

Apache License 2.0
25 stars 5 forks source link

feat!: view callback and layout functionality improvements #239

Closed jokerttu closed 2 months ago

jokerttu commented 2 months ago

Fixes the NavigationView callback registration issue when using multiple view instances. Resolves navigation view scaling issues by removing the mandatory height and width properties and adding support for an optional style property (breaking change). This allows developers to use flex or width/height parameters with percentage values.

Fixes #28 Fixes #192 Fixes #233 Partially fixes #235

BREAKING CHANGE: The height and width properties have been removed from NavigationView in favor of an optional style property.

ArturoSalazarB16 commented 2 months ago

Nit: For future PRs that aren't too critical to get out, is it possible to stat incrementally adding unit test coverage along with our changes?

ArturoSalazarB16 commented 2 months ago

This is a great improvement, thanks Joonas!

jokerttu commented 2 months ago

Nit: For future PRs that aren't too critical to get out, is it possible to stat incrementally adding unit test coverage along with our changes?

Most definetely yes. We should start incrementally adding unit test (and integratiojn test) coverage with future changes