googlemaps / v3-utility-library

Utility libraries for Google Maps JavaScript API v3
Apache License 2.0
1.1k stars 1.3k forks source link

feat: Support for @types/google.maps #694

Closed piotter121 closed 3 years ago

piotter121 commented 3 years ago

Fixes #690 🦕

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

piotter121 commented 3 years ago

@googlebot I signed it!

jpoehnelt commented 3 years ago

@piotter121 Are you primarily interested in the jest mocks?

piotter121 commented 3 years ago

No, but I am going to.

piotter121 commented 3 years ago

@jpoehnelt When can we expect to get this changes in new versions of NPM packages?

jpoehnelt commented 3 years ago

https://www.npmjs.com/package/@googlemaps/jest-mocks has been published.

jpoehnelt commented 3 years ago

@piotter121 I split jest-mocks into a separate repo, https://github.com/googlemaps/js-jest-mocks

piotter121 commented 3 years ago

Good to see @googlemaps/jest-mocks published, but primarily I was interested in @googlemaps/ogc and @googlemaps/markermanager as I wrote in #690.

jpoehnelt commented 3 years ago

got it. will publish those and split to separate repo too