search

googleooer / AnvilFix-issues

Report AnvilFix bugs here
0 stars 0 forks source link

[BUG] Combining Protection and Fire Protection Keeps Both #3

Open DavidMacDonald11 opened 1 year ago

DavidMacDonald11 commented 1 year ago

Describe the bug The mod allows the different protections to join onto one piece of armor.

To Reproduce Steps to reproduce the behavior:

  1. Use an enchanter to get Protection on one piece of armor.
  2. Use an enchanter to get Fire/Blast/Projectile protection on another piece of the same armor.
  3. Place them in an anvil. In either order, it allows both protections to remain.

Expected behavior I expect one of the protections to be removed in the normal vanilla way.

Screenshots 2023-11-18_12 28 34 2023-11-18_12 28 37 2023-11-18_12 28 38

Desktop (please complete the following information):

Additional context We are running on a server modded with this mod. One of us has the mod on our client, the other does not. In both cases, this behavior occurs.

DavidMacDonald11 commented 1 year ago

I notice it also allows channeling and riptide on the same trident. 2023-11-18_17 21 42

DavidMacDonald11 commented 1 year ago

I'd like to say that I'm currently working to fix this. I have also found a few other bugs. Then, I will do a pull request.

googleooer commented 1 year ago

Sorry, I've been incredibly busy with other projects, I'll get back to working on this mod eventually and probably rewrite it properly. I'm open to approving pull requests

DavidMacDonald11 commented 1 year ago

No worries, I totally understand! Its fun to work through the code so I don't mind; I'm just glad this mod exists for my friends and I.