search

googleprojectzero / domato

DOM fuzzer
https://googleprojectzero.blogspot.ch/2017/09/the-great-dom-fuzz-off-of-2017.html
Apache License 2.0
1.69k stars 278 forks source link

Spelling maybe intentional #6

Closed jsoref closed 7 years ago

jsoref commented 7 years ago

I'm not sure what the goal is here.

If you're intentionally misspelling tokens, it'd be helpful if you annotated them as such. It's also possible to do something like:

cssproperty = <display_token>: <cssproperty_display>
display_token = <display_spellings>
# we're intentionally misspelling display because ....
display_spellings = diplay
display_spellings = dipslay
display_spellings = display
ifratric commented 7 years ago

Interesting, some of these are probably my fault but some of these were automatically extracted from Chrome layout tests, which indicates spelling errors over there.

Unfortunately I cannot accept the patch as is because it would create some duplicate entries, for example there is already a rule <cssproperty_value> = <cssproperty_display> so renaming <cssproperty_value> = <cssproperty_diplay> to <cssproperty_value> = <cssproperty_display> would create an unnecessary duplicate.

However I went over all the cases you pointed out and made the relevant changes. Thanks for pointing those issues out!

jsoref commented 7 years ago

Running my tool on Chrome is on my todo list, but it'll take time...

For people curious, @ifratric 's fixes based on this are: 836bf40