googleprojectzero / functionsimsearch

Some C++ example code to demonstrate how to perform code similarity searches using SimHashing.
Apache License 2.0
559 stars 97 forks source link

De-duplicate the feature generator between dyninstfeaturegenerator.cpp and flowgraphwithinstructions.cpp #7

Open thomasdullien opened 5 years ago

thomasdullien commented 5 years ago

There's a comment about de-duplicating this code in dyininstfeaturegenerator; the current duplication of the code makes it very brittle.

The performance cost of forcing the dyninstfeaturegenerator to construct a Flowgraphwithinstructions instance is nontrivial, but code duplication is evil.