Why not set a default storagePath? - Githubissues

googleprojectzero / fuzzilli

A JavaScript Engine Fuzzer

Apache License 2.0

1.89k stars 305 forks source link

Why not set a default storagePath? #217

Open Lqingyu opened 3 years ago

saelo commented 3 years ago

So I guess there are at least two issues with that:

What to do if the directory already exists? Should one of --resume or --overwrite be the default as well (probably not --overwrite?) or do we just error out here in that case
Workers don't use a storagePath: https://github.com/googleprojectzero/fuzzilli/blob/f31ba8ee5f1d7d5f338a0d047a55d21b13494f7a/Cloud/GCE/start.sh#L205

That said, maybe we could add an explicit --no-storage flag or something like that, or we could turn this line https://github.com/googleprojectzero/fuzzilli/blob/f31ba8ee5f1d7d5f338a0d047a55d21b13494f7a/Sources/FuzzilliCli/main.swift#L462 into a fatal error, so I'm open to suggestions here.