googlesamples / android-media-controller

Apache License 2.0
432 stars 132 forks source link

Pass the extras bundle to the playFromMediaId instead of null #13

Open dgiannakop opened 4 years ago

dgiannakop commented 4 years ago

When setting the extras on the description of a MediaItem we expect the same bundle to be passed along on playFromMediaId.

Correct me if I am wrong, but that is the behaviour we observe on the android automotive and android auto and wanted to make it consistent.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

dgiannakop commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

fllaryora commented 6 months ago

I tested It and When I receive it on a MediaLibrarySession.Callback the method onAddMediaItems I find the extras of the requestedMetadata of the media empty

If I want to try something like: https://developer.android.com/guide/components/intents-common#PlaySearch

adb shell am start -n com.example.android.mediacontroller/.MediaAppControllerActivity --es com.example.android.mediacontroller.SEARCH "jazz?"  --es android.intent.extra.focus "vnd.android.cursor.item/genre" --es android.intent.extra.genre "jazz"

The rest of the extras are vanished.