googlesamples / android-media-controller

Apache License 2.0
446 stars 129 forks source link

Enable desugaring to fix linter errors #29

Closed nielsvanvelzen closed 3 years ago

nielsvanvelzen commented 3 years ago

This projects currently has 4 linter errors because features not available in older API versions were used. Fortunately this can be fixed easily by enabling desugaring.

Additionally this PR updates the Android Gradle plugin to 4.1.2 (from 3.6.3) and Gradle to 6.5 (from 5.6) so we can use the desugaring support.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

nielsvanvelzen commented 3 years ago

@googlebot I signed it!

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

nielsvanvelzen commented 3 years ago

Seems like there is no interest to merge this so I'm closing the PR.