googlesamples / android-media-controller

Apache License 2.0
432 stars 132 forks source link

Handling release of a MediaSessionCompat #7

Closed valeriia-shchukina closed 5 years ago

valeriia-shchukina commented 5 years ago

MediaSession is supposed to be released in case the media application has crashed while being connected to a MediaController. If the MediaController doesn't handle the onSessionDestroyed() it's possible that the old media session and old TransportControls are reused, which would result in a broken state.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
valeriia-shchukina commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

googlebot commented 5 years ago

CLAs look good, thanks!

nic0lette commented 5 years ago

Thank you for the contribution!