Flipped return Landmarks coordinates

googlesamples / android-vision

Deprecated: The Mobile Vision API is now a part of ML Kit: Check out this repo:

https://github.com/firebase/quickstart-android/tree/master/mlkit

Apache License 2.0

2.92k stars 1.73k forks source link

Flipped return Landmarks coordinates #430

Open Sinket opened 5 years ago

Sinket commented 5 years ago

I've noticed that returned landmark coordinates are not relative to the subject (as speced here: Landmark. Instead, they are returned relative to the observer/camera. Also, the NOSE_BASE landmark and face frame are much accurate(the frame is square instead of a rectangle and nose landmark points at nose tip). Actually, I don't see any of those as an issue as it simplifies things in my case. It is just that I've observed that because my app started to misbehave so I would like to know if those changes are long-term or bugs indeed.

This is observed on last gen devices 9 (Pixel 2 & 3, Samsung S3/S4)

alain-muller-ariadnext commented 5 years ago

Just realized it too : it seems like the google play services Vision API installed on old phones (HTC Desire 620 running KitKat) is OK, but for Lollipop on a Nexus 4 up to actual phones (Pixel 3), the LEFT_EYE and RIGHT_EYE landmark are inverted!

Sinket commented 5 years ago

I see the 'new' behaviour on:

Pixel 1, 2 & 3
Samsung Galaxy S6 Edge
Samsung Tab S3 & S4
Samsung Galaxy S8
Nexus 5
Huawei Mate 10 lite

Still behave the old way:

Sony Xperia D3
Motorola G5S+

I would not say it's up the the vision/Android's version since that Motorola I've tested is on Android 8 with GPS 17.4.55 version.

I actually like the new behaviour. I've also noticed that face landmarks are more accurate (especially when compared to Mac/iOS). The face bounding box is like square instead of a 'rect'. I'd just like to know whether is this long term or a bug :)