googlesamples / android-vision

Deprecated: The Mobile Vision API is now a part of ML Kit: Check out this repo:
https://github.com/firebase/quickstart-android/tree/master/mlkit
Apache License 2.0
2.92k stars 1.73k forks source link

No support for Raw Bytes from scan #85

Closed djak250 closed 7 years ago

djak250 commented 8 years ago

Some barcode implementations include a FNC1 character, specifically CODE_128's. These are necessary to detect in the event that a barcode contains two variable length values encoded to denote the end of one section, and the beginning of the next identifier.

I attempted to get the bytes from the rawData from a barcode, but the FNC1 character byte is missing. I've confirmed that the barcode does indeed contain one with zxing.

pchx-zz commented 8 years ago

I've confirmed that our Code128 implementation doesn't handle FNC characters at all. We'll look into returning control codes in the rawValue for future releases.

djak250 commented 8 years ago

Awesome. Thanks for giving me an update. We use them often in our mobile solution, and I'd love to read it in quickly in-app instead of outsourcing the functionality to zxing using Barcode Scanner.

pchx-zz commented 7 years ago

The latest version of our Barcode API (part of Google Play Services 10.0) now returns FNC1 characters in Code128 results.