search

googlesamples / arcore-depth-lab

ARCore Depth Lab is a set of Depth API samples that provides assets using depth for advanced geometry-aware features in AR interaction and rendering. (UIST 2020)
https://augmentedperception.github.io/depthlab/
Apache License 2.0
780 stars 153 forks source link

URP? #28

Closed mohsen123 closed 1 year ago

mohsen123 commented 3 years ago

Isn't it supporting URP?

tcdat96 commented 3 years ago

I'm trying URP but it doesn't seem to work. Did you figure it out?

mohsen123 commented 3 years ago

I'm trying URP but it doesn't seem to work. Did you figure it out? Not Yet! seems some shaders need some changes.

ruofeidu commented 3 years ago

Sorry but I haven't used URP so far. May I ask which scenes would you like to transfer to URP? Avatar locomotion or object placement?

mohsen123 commented 3 years ago

Sorry but I haven't used URP so far. May I ask which scenes would you like to transfer to URP? Avatar locomotion or object placement?

My target is point cload one, but I tried many Examples, UI, even the Target, is working fine but no Camera appears in the bg [black screen], maybe there is an issue with ARBackground shader,

ruofeidu commented 3 years ago

We have a new Point Cloud scene using raw Depth API now using both AR Foundation and ARCore Unity SDK. Please feel free to check it out: https://github.com/googlesamples/arcore-depth-lab/releases

pinklover91 commented 2 years ago

Hi I'm trying to build the arcore-unity-sdk branch using URP, however, I keep getting black screen for my camera, because we don't have ARBackgroundRendererFeature in ARCore. Does anyone encounter this issue before? Do you have any workaround to get this work?

ruofeidu commented 2 years ago

Hi pinklover91, would you like to ensure your Unity version is Unity 2019.4.*? Sorry but I haven't got bandwidth to try the latest Unity versions, but it works well on my Windows, Mac, and Linux.

ruofeidu commented 2 years ago

BTW, you need to "Download and import arcore-unity-sdk-1.24.0.unitypackage or newer into the sample project. " See the README.md in that branch.

pinklover91 commented 2 years ago

Hi pinklover91, would you like to ensure your Unity version is Unity 2019.4.*? Sorry but I haven't got bandwidth to try the latest Unity versions, but it works well on my Windows, Mac, and Linux.

Hi yes, I'm using 2019.4.25f1.

ruofeidu commented 2 years ago

BTW, you need to "Download and import arcore-unity-sdk-1.24.0.unitypackage or newer into the sample project. " See the README.md in that branch.

Did you do this as well?

pinklover91 commented 2 years ago

BTW, you need to "Download and import arcore-unity-sdk-1.24.0.unitypackage or newer into the sample project. " See the README.md in that branch.

Did you do this as well?

Hi Ruofeidu, thank you so much for your hard work, taking your time replying and testing as well. I really appreciate it. Yes, I did this as well. Using both 1.25.0 and 1.24.0 versions. Still encountering black screen using URP, only when I remove my URP package, then I will be able to see my camera feed. May I know if there's any particular setting similar to ARBackgroundRendererFeature settings in URP like AR Foundation? Or another alternatives workaround to solve this issue?

ruofeidu commented 2 years ago

Hi pinklower91,

I recently updated the app in Play Store and build it with Unity 2019.4.36f and I can verify it's working. Unity 2019.4.37f has some bugs in collision scene. But let me know if you are still encountering this bug.

Best, Ruofei